Skip to content

Fix showing logic for notices, add compact style #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2025
Merged

Fix showing logic for notices, add compact style #107

merged 8 commits into from
Apr 25, 2025

Conversation

christophfriedrich
Copy link
Collaborator

No description provided.

@christophfriedrich christophfriedrich linked an issue Apr 23, 2025 that may be closed by this pull request
Improve support for the Federation Extension #97
Closed
4 tasks
@christophfriedrich
Copy link
Collaborator Author

Possibly convert to draft, I still want to add an example for the compact style but need the fixes from master for that

m-mohr
m-mohr reviewed Apr 23, 2025
View reviewed changes
@m-mohr m-mohr force-pushed the improve-federation-support-continued branch from 1a651aa to 616ea05 Compare April 23, 2025 13:55
@m-mohr
Copy link
Member

m-mohr commented Apr 23, 2025 •
edited
Loading

Generally looks good, thanks. I rebased the PR to include the main changes and left one comment with regards to the Description heading.

@christophfriedrich
Copy link
Collaborator Author

christophfriedrich commented Apr 25, 2025 •
edited
Loading

Thanks for incorporating the master changes; "Description" heading discussion has been addressed and resolved, same for #108 that came up in the corresponding Web Editor PR, example has been added -> ready to merge IMO

Maybe check if the changelog contains everything you want (I only mentioned the added compact prop there)

m-mohr
m-mohr reviewed Apr 25, 2025
View reviewed changes
m-mohr
m-mohr approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.
Left one additional comment that could be applied throughout the PR for a slightly improved readability of the code.

@m-mohr m-mohr merged commit b52cc53 into master Apr 25, 2025
@m-mohr m-mohr deleted the improve-federation-support-continued branch April 25, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve support for the Federation Extension
2 participants
@christophfriedrich @m-mohr